relcaimspace: add nodeID to error message #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergify
bot
requested review from
nixpanic,
Rakshith-R,
yati1998 and
Yuggupta27
Rakshith-R
requested changes
Oct 18, 2022
| @@ -252,7 +252,7 @@ func (r *ReclaimSpaceJobReconciler) reconcile( | |||
| } | |||
|
|
|||
| if !controllerFound && !nodeFound { | |||
| err = errors.New("Controller and Node Client not found") | |||
| err = fmt.Errorf("Controller and Node Client not found for %s nodeID", target.nodeID) | |||
There was a problem hiding this comment.
Suggested change
| err = fmt.Errorf("Controller and Node Client not found for %s nodeID", target.nodeID) | |
| err = fmt.Errorf("Controller and Node Client not found for %q nodeID", target.nodeID) |
add quotes so it stands out ?
| @@ -403,7 +403,7 @@ func (r *ReclaimSpaceJobReconciler) nodeReclaimSpace( | |||
| target.nodeID, | |||
| identity.Capability_ReclaimSpace_ONLINE) | |||
| if nodeClient == nil { | |||
| return nil, errors.New("node Client not found") | |||
| return nil, fmt.Errorf("node Client not found for %s nodeID", target.nodeID) | |||
There was a problem hiding this comment.
Suggested change
| return nil, fmt.Errorf("node Client not found for %s nodeID", target.nodeID) | |
| return nil, fmt.Errorf("node Client not found for %q nodeID", target.nodeID) |
add quotes so it stands out ?
add nodeID to error message to provide more details for debugging. Signed-off-by: Madhu Rajanna <[email protected]>
Madhu-1
force-pushed
the
add-nodeid-for-log
branch
from
8792c95 to
cdda823
Compare
Rakshith-R
approved these changes
Oct 18, 2022
yati1998
approved these changes
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add nodeID to error message to provide more details for debugging.
Signed-off-by: Madhu Rajanna [email protected]