controller: fix csiaddonsnodes object deletion #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resolveEndpoint get the pod object to resolve the ip address as the pod object is deleted resolveEndpoint will fail to get the pod and it blocks the csiaddonsnodes object from getting deleted because of this logs will get flooded and other csiaddons operation might also fail. To fix this problem call resolveEndpoint only if the csiaddonsnodes object is not deleted. Signed-off-by: Madhu Rajanna <[email protected]>
mergify
bot
requested review from
nixpanic,
Rakshith-R,
yati1998 and
Yuggupta27
Rakshith-R
approved these changes
Oct 7, 2022
|
Looks good to me. Just needs manual testing at the moment, so please report back once done. |
[🎩︎]mrajanna@fedora ceph-csi $]kubectl get csiaddonsnodes -nrook-ceph
NAME NAMESPACE AGE DRIVERNAME ENDPOINT NODEID
csi-rbdplugin-provisioner-564d599ff9-tzrfd rook-ceph 7m7s rook-ceph.rbd.csi.ceph.com pod://csi-rbdplugin-provisioner-564d599ff9-tzrfd.rook-ceph:9070 minikube
csi-rbdplugin-vgdmh rook-ceph 7m49s rook-ceph.rbd.csi.ceph.com pod://csi-rbdplugin-vgdmh.rook-ceph:9070 minikube
[🎩︎]mrajanna@fedora ceph-csi $]
[🎩︎]mrajanna@fedora ceph-csi $]kuberc get po
NAME READY STATUS RESTARTS AGE
csi-rbdplugin-provisioner-564d599ff9-tzrfd 6/6 Running 0 7m20s
csi-rbdplugin-vgdmh 3/3 Running 0 10m
rook-ceph-mds-myfs-a-5cbfd6b469-dvxmm 1/1 Running 0 8m20s
rook-ceph-mds-myfs-b-5547585845-cgrcs 1/1 Running 0 8m19s
rook-ceph-mgr-a-58f5c6dc7c-nzzxl 1/1 Running 0 8m59s
rook-ceph-mon-a-6c84dbcf58-gnfww 1/1 Running 0 9m24s
rook-ceph-operator-7bd59d5dbf-md28b 1/1 Running 0 11m
rook-ceph-osd-0-6f9dc6d97b-j4nf5 1/1 Running 0 8m29s
rook-ceph-osd-prepare-minikube-vghnv 0/1 Completed 0 8m4s
rook-ceph-tools-79bc54b8d8-rw8mw 1/1 Running 0 11m
[🎩︎]mrajanna@fedora ceph-csi $]kuberc delete po/csi-rbdplugin-provisioner-564d599ff9-tzrfd
pod "csi-rbdplugin-provisioner-564d599ff9-tzrfd" deleted
[🎩︎]mrajanna@fedora ceph-csi $]kuberc get csiaddonsnodes -nrook-ceph
NAME NAMESPACE AGE DRIVERNAME ENDPOINT NODEID
csi-rbdplugin-provisioner-564d599ff9-pmqcm rook-ceph 4s rook-ceph.rbd.csi.ceph.com pod://csi-rbdplugin-provisioner-564d599ff9-pmqcm.rook-ceph:9070 minikube
csi-rbdplugin-vgdmh rook-ceph 8m13s rook-ceph.rbd.csi.ceph.com pod://csi-rbdplugin-vgdmh.rook-ceph:9070 minikube
[🎩︎]mrajanna@fedora ceph-csi $]kuberc get po
NAME READY STATUS RESTARTS AGE
csi-rbdplugin-provisioner-564d599ff9-pmqcm 6/6 Running 0 15s
csi-rbdplugin-vgdmh 3/3 Running 0 10m
rook-ceph-mds-myfs-a-5cbfd6b469-dvxmm 1/1 Running 0 8m42s
rook-ceph-mds-myfs-b-5547585845-cgrcs 1/1 Running 0 8m41s
rook-ceph-mgr-a-58f5c6dc7c-nzzxl 1/1 Running 0 9m21s
rook-ceph-mon-a-6c84dbcf58-gnfww 1/1 Running 0 9m46s
rook-ceph-operator-7bd59d5dbf-md28b 1/1 Running 0 11m
rook-ceph-osd-0-6f9dc6d97b-j4nf5 1/1 Running 0 8m51s
rook-ceph-osd-prepare-minikube-vghnv 0/1 Completed 0 8m26s
rook-ceph-tools-79bc54b8d8-rw8mw 1/1 Running 0 11m
[🎩︎]mrajanna@fedora ceph-csi $] |
|
Tested works as expected |
nixpanic
approved these changes
Oct 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolveEndpoint get the pod object to resolve the ip address as the pod object is deleted resolveEndpoint will fail to get the pod and it blocks the csiaddonsnodes object from getting deleted because of this logs will get flooded and other csiaddons operation might also fail.
To fix this problem call resolveEndpoint only if the csiaddonsnodes object is not deleted.
Signed-off-by: Madhu Rajanna [email protected]