add proto and service for volume replication #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rakshith-R
requested review from
nixpanic,
Madhu-1,
raghavendra-talur,
ShyamsundarR and
yati1998
yati1998
requested changes
Aug 19, 2022
Madhu-1
reviewed
Aug 19, 2022
| data, err := kube.GetSecret(ctx, rs.kubeClient, req.GetSecretName(), req.GetSecretNamespace()) | ||
| if err != nil { | ||
| klog.Errorf("Failed to get secret %s in namespace %s: %v", req.GetSecretName(), req.GetSecretNamespace(), err) | ||
| return nil, status.Error(codes.InvalidArgument, err.Error()) |
There was a problem hiding this comment.
Always try the internal server error if the invalid is not the right error.
| } | ||
|
|
||
| _, err = rs.controllerClient.PromoteVolume(ctx, | ||
| &csiReplication.PromoteVolumeRequest{ |
There was a problem hiding this comment.
PromoteVolReq also has the force option which you need to consider
| return nil, status.Error(codes.InvalidArgument, err.Error()) | ||
| } | ||
|
|
||
| _, err = rs.controllerClient.ResyncVolume(ctx, |
There was a problem hiding this comment.
Resync should return success or failure based on that we need to take few actions to reconcile the CR or not.
added required proto file and generate grpc library for internal communication for volume replication Signed-off-by: Rakshith R <[email protected]>
adding sidecar service for the volume replication service. Signed-off-by: Rakshith R <[email protected]>
Rakshith-R
force-pushed
the
add-vr-client
branch
from
f4611d1 to
cfb4fb9
Compare
done
Negative, this purely csi-addons design of internal proto and sidecar, I'll add them for controller part.Other requested changes are addressed, PTAL. |
Madhu-1
approved these changes
Aug 22, 2022
6 tasks
yati1998
approved these changes
Aug 22, 2022
Nikhil-Ladha
pushed a commit
to Nikhil-Ladha/kubernetes-csi-addons
that referenced
this pull request
Sep 24, 2024
Syncing latest changes from upstream main for kubernetes-csi-addons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rakshith R [email protected]
Signed-off-by: Rakshith R [email protected]
Updates: #116