provide option to set MaxConcurrentReconciles #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergify
bot
requested review from
nixpanic,
Rakshith-R,
yati1998 and
Yuggupta27
Current MaxConcurrentReconciles is 1, which is the default, meaning only one request will be processed at a time. This is not useful when we have 100/1000 CR to reconcile, which can affect the performance. This PR provides a way to set the MaxConcurrentReconciles to the user's desired value so that the user can tune the configuration based on the requirement. Note:- Currently we have performance issue in DR VolRep because of this one, the failover and failback time are slightly affected because of the default value. with this, things will be better and same change need to be done when we add VolRep Reconciler also. Signed-off-by: Madhu Rajanna <[email protected]>
|
@nixpanic added doc for the command line arguments PTAL |
Madhu-1
force-pushed
the
option-max-reconcile
branch
2 times, most recently
from
a14f248 to
7e1c664
Compare
document available command line agruments avaiable for configuration when starting the controller. Signed-off-by: Madhu Rajanna <[email protected]>
Madhu-1
force-pushed
the
option-max-reconcile
branch
from
7e1c664 to
9be5a13
Compare
raghavendra-talur
approved these changes
Aug 17, 2022
Rakshith-R
reviewed
Aug 18, 2022
| flag.StringVar(&metricsAddr, "metrics-bind-address", ":8080", "The address the metric endpoint binds to.") | ||
| flag.StringVar(&probeAddr, "health-probe-bind-address", ":8081", "The address the probe endpoint binds to.") | ||
| flag.BoolVar(&enableLeaderElection, "leader-elect", false, | ||
| "Enable leader election for controller manager. "+ | ||
| "Enabling this will ensure there is only one active controller manager.") | ||
| flag.DurationVar(&reclaimSpaceTimeout, "reclaim-space-timeout", defaultTimeout, "Timeout for reclaimspace operation") | ||
| flag.IntVar(&maxConcurrentReconciles, "max-concurrent-reconciles", 100, "Maximum number of concurrent reconciles") |
There was a problem hiding this comment.
Suggested change
| flag.IntVar(&maxConcurrentReconciles, "max-concurrent-reconciles", 100, "Maximum number of concurrent reconciles") | |
| flag.IntVar(&maxConcurrentReconciles, "max-concurrent-reconciles", 100, "Maximum number of concurrent reconciles") |
Do we really need 100 as default value ?
most controllers have just a single loop.
There was a problem hiding this comment.
Yes, having 100 in default doesn't cause any harm, and also, it doesn't make sense to have different configurations per controller. This helps to have concurrent reconciles, which fasten the process when we have more requests.
Rakshith-R
approved these changes
Aug 18, 2022
yati1998
approved these changes
Aug 19, 2022
Madhu-1
added a commit
to Madhu-1/kubernetes-csi-addons
that referenced
this pull request
Aug 23, 2022
Added option to set MaxConcurrentReconciles for VolumeReplication which was pending and for all other controllers this is set in csi-addons#203 Signed-off-by: Madhu Rajanna <[email protected]>
Madhu-1
added a commit
to Madhu-1/kubernetes-csi-addons
that referenced
this pull request
Aug 24, 2022
Added option to set MaxConcurrentReconciles for VolumeReplication which was pending and for all other controllers this is set in csi-addons#203 Signed-off-by: Madhu Rajanna <[email protected]>
Madhu-1
added a commit
to Madhu-1/kubernetes-csi-addons
that referenced
this pull request
Aug 24, 2022
Added option to set MaxConcurrentReconciles for VolumeReplication which was pending and for all other controllers this is set in csi-addons#203 Signed-off-by: Madhu Rajanna <[email protected]>
Madhu-1
added a commit
to Madhu-1/kubernetes-csi-addons
that referenced
this pull request
Aug 24, 2022
Added option to set MaxConcurrentReconciles for VolumeReplication which was pending and for all other controllers this is set in csi-addons#203 Signed-off-by: Madhu Rajanna <[email protected]>
mergify bot
pushed a commit
that referenced
this pull request
Aug 24, 2022
Added option to set MaxConcurrentReconciles for VolumeReplication which was pending and for all other controllers this is set in #203 Signed-off-by: Madhu Rajanna <[email protected]>
openshift-cherrypick-robot
referenced
this pull request
in openshift-cherrypick-robot/kubernetes-csi-addons
Aug 30, 2022
Added option to set MaxConcurrentReconciles for VolumeReplication which was pending and for all other controllers this is set in red-hat-storage#203 Signed-off-by: Madhu Rajanna <[email protected]>
Nikhil-Ladha
pushed a commit
to Nikhil-Ladha/kubernetes-csi-addons
that referenced
this pull request
Sep 18, 2024
Syncing latest changes from upstream main for kubernetes-csi-addons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current MaxConcurrentReconciles is 1, which is the default, meaning only one request will be processed at a time. This is not useful when we have 100/1000 CR to reconcile, which can affect the performance. This PR provides a way to set the MaxConcurrentReconciles to the user's desired value so that the user can tune the configuration based on the requirement.
Note:- Currently we have performance issue in DR VolRep because of this one, the failover and failback time are slightly affected because of the default value. with this, things will be better and same change need to be done when we add VolRep Reconciler also.
Signed-off-by: Madhu Rajanna [email protected]