-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add quotes while executing sed for replace & skip range #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the generated base csv to work, quote needs to be added around replaces and skip_range values. Signed-off-by: Rakshith R <[email protected]>
Madhu-1
approved these changes
Apr 21, 2022
Please add an example (as a comment) on how you tested and verified this. |
@nixpanic,PTAL Before
after
|
nixpanic
approved these changes
Apr 21, 2022
Nikhil-Ladha
pushed a commit
to Nikhil-Ladha/kubernetes-csi-addons
that referenced
this pull request
Jun 18, 2024
Syncing latest changes from upstream main for kubernetes-csi-addons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the generated base csv to work, quote needs to be added
around replaces and skip_range values.
Signed-off-by: Rakshith R [email protected]
cc @Madhu-1 @nixpanic @yati1998