cleanup: removes the docs from README to docs folder #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR would require #123 to get merged first. |
nixpanic
reviewed
Feb 28, 2022
nixpanic
reviewed
Feb 28, 2022
Madhu-1
reviewed
Mar 1, 2022
Madhu-1
reviewed
Mar 9, 2022
nixpanic
reviewed
Mar 14, 2022
nixpanic
requested changes
Mar 14, 2022
nixpanic
previously approved these changes
Mar 15, 2022
Madhu-1
reviewed
Mar 15, 2022
docs/deploy-controller.md
Outdated
|
|
||
| * The "rbac.yaml" creates the required rbac. | ||
|
|
||
| * The setup-controller creates the csi-addons-controller-manager. |
There was a problem hiding this comment.
setup-controller needs to be quoted as well?
There was a problem hiding this comment.
and it should be setup-controller.yaml?
This commit removes the installations methods of CSI-Addons controller from the README file to deploy-controller.md inside the docs folder. This will keep the README clean and have all documentation at one place. Signed-off-by: yati1998 <[email protected]>
Madhu-1
approved these changes
Mar 29, 2022
| @@ -164,7 +117,6 @@ deployment.apps/csi-addons-controller-manager created | |||
|
|
|||
| The [Contribution Guidelines](CONTRIBUTING.md) contain details on the process | |||
| to contribute to this project. | |||
|
|
|||
There was a problem hiding this comment.
Not required, just removed the extra space.
nixpanic
approved these changes
Mar 29, 2022
Nikhil-Ladha
pushed a commit
to Nikhil-Ladha/kubernetes-csi-addons
that referenced
this pull request
May 27, 2024
Syncing latest changes from upstream main for kubernetes-csi-addons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the installations methods of CSI-Addons
controller from the README file to deploy-controller.md inside
the docs folder. This will keep the README clean and have all
documentation at one place.
Signed-off-by: yati1998 [email protected]