Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle non implemented error for getVolumeReplicationInfo RPC #236

Closed
yati1998 opened this issue Sep 13, 2022 · 2 comments · Fixed by #295
Closed

Handle non implemented error for getVolumeReplicationInfo RPC #236

yati1998 opened this issue Sep 13, 2022 · 2 comments · Fixed by #295
Assignees
@Rakshith-R
Labels
bug Something isn't working

Comments

@yati1998
Copy link
Contributor

We need to handle the nonimplemented error for RPC getVolumeReplication call.
For more details please check this:
#232 (review)
@Rakshith-R Rakshith-R added the bug Something isn't working label Sep 14, 2022
@Madhu-1
Copy link
Member

Madhu-1 commented Nov 7, 2022

@yati1998 you are planning to fix this one soon?

@yati1998
Copy link
Contributor Author

yati1998 commented Nov 8, 2022

@yati1998 you are planning to fix this one soon?

yes.

@Rakshith-R Rakshith-R mentioned this issue Nov 21, 2022
Closed
Rakshith-R added a commit to Rakshith-R/kubernetes-csi-addons that referenced this issue Feb 6, 2023
@Rakshith-R
controller/replication: add UnimplementedError for getVolRepInfo()
46c2dad 
This commit adds code to handle UnimplmentedError from
getVolumeReplicationInfo rpc. The controller wil now
ignore this error and not requeue the request.

Fixes: csi-addons#236

Signed-off-by: Rakshith R <[email protected]>
@Rakshith-R Rakshith-R assigned Rakshith-R and unassigned yati1998 Feb 6, 2023
Rakshith-R added a commit to Rakshith-R/kubernetes-csi-addons that referenced this issue Feb 6, 2023
@Rakshith-R
controller/replication: add UnimplementedError for getVolRepInfo()
ba70a84 
This commit adds code to handle UnimplmentedError from
getVolumeReplicationInfo rpc. The controller wil now
ignore this error and not requeue the request.

Fixes: csi-addons#236

Signed-off-by: Rakshith R <[email protected]>
@Rakshith-R Rakshith-R mentioned this issue Feb 6, 2023
Merged
Rakshith-R added a commit to Rakshith-R/kubernetes-csi-addons that referenced this issue Feb 7, 2023
@Rakshith-R
controller/replication: add UnimplementedError for getVolRepInfo()
8f2a31d 
This commit adds code to handle UnimplmentedError from
getVolumeReplicationInfo rpc. The controller wil now
ignore this error and not requeue the request.

Fixes: csi-addons#236

Signed-off-by: Rakshith R <[email protected]>
@mergify mergify bot closed this as completed in #295 Feb 7, 2023
mergify bot pushed a commit that referenced this issue Feb 7, 2023
@Rakshith-R @mergify
controller/replication: add UnimplementedError for getVolRepInfo()
90f59d1 
This commit adds code to handle UnimplmentedError from
getVolumeReplicationInfo rpc. The controller wil now
ignore this error and not requeue the request.

Fixes: #236

Signed-off-by: Rakshith R <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Rakshith-R Rakshith-R

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

controller/replication: add UnimplementedError for getVolRepInfo() Rakshith-R/kubernetes-csi-addons
3 participants
@Madhu-1 @yati1998 @Rakshith-R