Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add github actions for static tools #12

Closed
3 of 4 tasks
Madhu-1 opened this issue Dec 14, 2021 · 3 comments
Closed
3 of 4 tasks

Add github actions for static tools #12

Madhu-1 opened this issue Dec 14, 2021 · 3 comments
Assignees
@nixpanic @riya-singhal31
Labels
enhancement New feature or request testing Improvements for CI and testing

Comments

@Madhu-1
Copy link
Member

Madhu-1 commented Dec 14, 2021 •
edited by riya-singhal31
Loading

Add GitHub actions for static tools.

  • golint
  • shellscripts
  • yaml files
  • .md files

etc.
@nixpanic nixpanic mentioned this issue Dec 17, 2021
Merged
@nixpanic nixpanic added the enhancement New feature or request label Jan 6, 2022
nixpanic referenced this issue in nixpanic/kubernetes-csi-addons Feb 3, 2022
@openshift-merge-robot
Merge pull request #12 from openshift-cherrypick-robot/cherry-pick-11…
64758e1 
…-to-release-4.10

[release-4.10] sync upstream main branch to downstream
nixpanic added a commit that referenced this issue Jul 18, 2022
@nixpanic
service: add <url>/scene/<scene>/<event> support
5f1c79e 
The newly added URL scheme adds support for selecting a scene,
independently of the RoboFlow state. This can be useful when referees
prepare for the next game (InPlay scene starts), but the players are
still recovering during the game-break (BetweenGames scene).

Closes: #12
nixpanic added a commit that referenced this issue Jul 18, 2022
@nixpanic
scene: add Note to display an exceptional state
0324c31 
With #12 addressed, it is now possible to use
<url>/scene/note/<event>/<name> to generate an image based on the
templates `note.svg` (with `@@text@@` placeholder). Different
descriptions for standard notifications are configured in
`localdata/notes.json`.

Closes: #11
@nixpanic nixpanic added the testing Improvements for CI and testing label Jul 29, 2022
@nixpanic
Copy link
Collaborator

golangci-lint was added with #365

@nixpanic nixpanic mentioned this issue Jun 14, 2023
Merged
mergify bot pushed a commit that referenced this issue Jun 16, 2023
@nixpanic @mergify
ci: add yaml-lint GitHub Workflow
13ce65f 
Initial `yamllint` validation for all GitHub Workflows.

Updates: #12
Signed-off-by: Niels de Vos <[email protected]>
@nixpanic nixpanic mentioned this issue Jul 6, 2023
Merged
@riya-singhal31 riya-singhal31 mentioned this issue Jul 14, 2023
Merged
@riya-singhal31
Copy link
Contributor

Hi @Madhu-1 , AFAIK we don't have any shell scripts currently, so do we still want to have the github action for shellscripts?

@Madhu-1
Copy link
Member Author

Madhu-1 commented Jul 17, 2023

don't have any shell scripts currently, so do we still want to have the github action for shellscripts?

IF we don't have it we can skip it. Thank you @riya-singhal31 , closing this as completed

@Madhu-1 Madhu-1 closed this as completed Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nixpanic nixpanic

@riya-singhal31 riya-singhal31

Labels
enhancement New feature or request testing Improvements for CI and testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nixpanic @Madhu-1 @riya-singhal31