Feat/reinvite staff user #495
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We'll need to merge #475 and rebase this branch, before we can merge this one. |
landonshumway-ia
suggested changes
Jan 24, 2025
backend/compact-connect/lambdas/python/common/cc_common/data_model/user_client.py
Show resolved
Hide resolved
backend/compact-connect/lambdas/python/common/cc_common/data_model/user_client.py
Outdated
Show resolved
Hide resolved
backend/compact-connect/lambdas/python/common/tests/function/__init__.py
Show resolved
Hide resolved
landonshumway-ia
approved these changes
Jan 24, 2025
landonshumway-ia
approved these changes
Jan 27, 2025
jusdino
force-pushed
the
feat/reinvite-staff-user
branch
from
d460d66 to
53eca9b
Compare
jusdino
force-pushed
the
feat/reinvite-staff-user
branch
from
53eca9b to
10419bb
Compare
|
@jlkravitz , this one is ready for you! |
jlkravitz
reviewed
Jan 30, 2025
...end/compact-connect/lambdas/python/common/tests/function/test_data_model/test_user_client.py
Show resolved
Hide resolved
Comment on lines
+172
to
+184
| allowed_jurisdictions = get_allowed_jurisdictions(compact=compact, scopes=get_event_scopes(event)) | ||
|
|
||
| # None means they are a compact admin - no jurisdiction restrictions at all | ||
| user = config.user_client.get_user_in_compact(compact=compact, user_id=user_id) | ||
| if allowed_jurisdictions is not None: | ||
| allowed_jurisdictions = set(allowed_jurisdictions) | ||
| user = config.user_client.get_user_in_compact(compact=compact, user_id=user_id) | ||
| user_jurisdictions = user['permissions']['jurisdictions'].keys() | ||
| common_jurisdictions = allowed_jurisdictions.intersection(user_jurisdictions) | ||
|
|
||
| # We won't show that the user even exists, if they have no common jurisdictions | ||
| if not common_jurisdictions: | ||
| raise CCNotFoundException('User not found') |
There was a problem hiding this comment.
In what scenario will this fail, and why is this code necessary to reinvite a user?
There was a problem hiding this comment.
This will return a 404 in the event that a user calls this endpoint with an id for a user they don't have permission to see (i.e. a board admin in Ohio tries to reinvite a user who has no permissions in Ohio).
...ompact-connect/lambdas/python/staff-users/tests/function/test_handlers/test_reinvite_user.py
Outdated
Show resolved
Hide resolved
|
@jlkravitz all resolved, I think |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description List
POST staff-user/:userId/reinviteendpoint that will resend an invite email, resetting the user's password if necessaryTesting List
Closes #
closes #476