Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frontend/Update nanoid dependency #400

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Frontend/Update nanoid dependency #400

merged 1 commit into from
Dec 17, 2024

Conversation

jsandoval81
Copy link
Collaborator

Requirements List

  • yarn install --ignore-engines

Description List

Testing List

  • yarn install --ignore-engines
  • yarn test:unit:all should run without errors or warnings
  • yarn serve should run without errors or warnings
  • yarn build should run without errors or warnings
  • Code review

Closes #399

@jsandoval81
Copy link
Collaborator Author

@jlkravitz This is ready for your review.

jlkravitz
jlkravitz approved these changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@jlkravitz jlkravitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@isabeleliassen good to go

@isabeleliassen isabeleliassen merged commit 0978070 into csg-org:development Dec 17, 2024
1 check passed
@jsandoval81 jsandoval81 deleted the frontend/nanoid-dependency-update branch January 29, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isabeleliassen isabeleliassen isabeleliassen approved these changes

@jlkravitz jlkravitz jlkravitz approved these changes

@carlsims carlsims Awaiting requested review from carlsims

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update frontend dependency
3 participants
@jsandoval81 @jlkravitz @isabeleliassen