Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CW2-30] Design event cards #37

Merged
merged 16 commits into from
Oct 18, 2024
Merged

[CW2-30] Design event cards #37

merged 16 commits into from
Oct 18, 2024

Conversation

derekxu04
Copy link
Collaborator

@derekxu04 derekxu04 commented Oct 17, 2024

  • TODO: have some message if there are no upcoming events

@derekxu04
Copy link
Collaborator Author

derekxu04 commented Oct 18, 2024

Some changes:

  • automatic sliding is too fast
  • see sponsors carousel -> do we want to refactor to just reuse that? but that one doesn't have buttons but pretty sure can just change props to include it
  • no carousel for previous rents, just display in a grid (as we will have too many...)
  • for home page, just have the carousel of upcoming events i think and then see all events for the events page

ACTUALLY UPDATE WITH CORRECT EVENT DATA -> in future should decide a process to do this (e.g. how often, when redeploy website, before automatic is done, maybe can write a script to do this for you manually before automating it properly)

@derekxu04
Copy link
Collaborator Author

image

@derekxu04 derekxu04 merged commit 3bda5ee into master Oct 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants