Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try to add param type in comments #297

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

xian18
Copy link

@xian18 xian18 commented Sep 30, 2022

Feature

Fix

Feature

  • Description of what's added
    try to add param type in comments

  • Gif of your feature if appropriate
    GIF

@cschlosser
Copy link
Owner

Thanks for your contribution @xian18 and sorry for not getting back to you earlier.

Unfortunately your change breaks existing behavior, could you please take a look at this and also add tests for your new feature?

@xian18
Copy link
Author

xian18 commented Jan 25, 2023

Add the test about template type in Parameters.test.ts.
Modify the logic of the parser to pass the tests.
Some types of keywords will be missing from the original logic, e.g.

int foo(unsigned int arg1);

type of paramenter arg1 will be unsigned, not unsigned int.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants