Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Language identifier for CUDA to correct one #273

Merged
merged 2 commits into from
Feb 25, 2022

Conversation

jobtijhuis
Copy link
Contributor

Fix

  • Issue: doxdocgen is not triggered for CUDA files because the current language identifier in the activationEvents triggers is cuda but this is not correct because on the VS Code website it lists cuda-cpp for CUDA —this issue was mainly noticed because doxdocgen was not working in CUDA files (.cu, .cuh).

  • Fix: CUDA support is added again by correcting the language identifier to the —at this time— correct value.

@cschlosser
Copy link
Owner

Hi @jobtijhuis ,

thanks for catching that!
Is it possible that the identifier has changed in the meantime?

Do you see a problem when keeping the old identifier and the one you proposed?

@codecov
Copy link

codecov bot commented Feb 24, 2022

Codecov Report

Merging #273 (f69c180) into master (9c8c583) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #273   +/-   ##
=======================================
  Coverage   93.36%   93.36%           
=======================================
  Files           5        5           
  Lines         814      814           
  Branches      242      242           
=======================================
  Hits          760      760           
  Misses         54       54           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c8c583...f69c180. Read the comment docs.

@jobtijhuis
Copy link
Contributor Author

I was using the Nvidia Nsight extension, but after looking at some other extensions they seem to use cuda as language identifier. It just seems that Microsoft together with Nvidia settled on cuda-cpp so that is what is on the official VSCode list. It will probably be good to support both.
I did not test the proposed change; I just changed the language of the .cu files to C++ as a temporary workaround to add documentation.

…d by extensions before Microsoft and Nvidia started using `cuda-cpp`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants