Use vscode.workspace.workspaceFolders[0] to construct SimpleGit instance. #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukester1975
changed the title
lukester1975
force-pushed
the
workspace-dir-fix
branch
from
5e28ff7 to
5dbedab
Compare
Allows per-workspace git user and email address.
lukester1975
force-pushed
the
workspace-dir-fix
branch
from
5dbedab to
e2aa1cb
Compare
Codecov Report
@@ Coverage Diff @@
## master #268 +/- ##
=======================================
Coverage 93.36% 93.36%
=======================================
Files 5 5
Lines 814 814
Branches 242 242
=======================================
Hits 760 760
Misses 54 54 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature
Or is it a fix...
Allows a per-workspace git user and email address.
Note that this change doesn't cope with multiple workspaces in a single vscode instance. It would probably have to defer the config lookup and use the appropriate workspace root for the file being edited at that point.
Thanks for the extension, hope this is useful and it should at least be good for most cases!
Regards