Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Re-add relative positioning to MenuList #355

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

csandman
Copy link
Owner

This PR closes #352

There was an issue with the menu scrolling behavior using the arrow keys due to removed relative positioning on the MenuList component. You can see where it was removed in V6 here: https://github.com/csandman/chakra-react-select/pull/341/files#diff-282462b390ca3390d40b92e5bb7575995e675a710c8958176ffbae47e15a3411L116

This was most likely removed by mistake in an attempt to clean up as many style overrides as possible.

Copy link

stackblitz bot commented Jan 16, 2025

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

pkg-pr-new bot commented Jan 16, 2025

Open in Stackblitzchakra-react-select-demo

npm i https://pkg.pr.new/chakra-react-select@355

commit: e92624b

Copy link

📊 Package size report   0.1%↑

File Before After
dist/index.js 31.0 kB 0.3%↑31.0 kB
dist/index.mjs 29.4 kB 0.3%↑29.5 kB
Total (Includes all files) 151.4 kB 0.1%↑151.5 kB
Tarball size 29.7 kB 0.3%↑29.8 kB
Unchanged files
File Size
dist/index.d.mts 19.6 kB
dist/index.d.ts 19.6 kB
LICENSE.md 1.1 kB
package.json 3.0 kB
README.md 47.8 kB

🤖 This report was automatically generated by pkg-size-action

@csandman csandman merged commit 228e951 into main Jan 16, 2025
5 checks passed
@csandman csandman deleted the fix/menu-list-positioning branch January 16, 2025 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Keyboard scrolling buggy when menu not absolutely positioned
1 participant