fix: Re-add relative positioning to MenuList #355
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #352
There was an issue with the menu scrolling behavior using the arrow keys due to removed relative positioning on the
MenuList
component. You can see where it was removed in V6 here: https://github.com/csandman/chakra-react-select/pull/341/files#diff-282462b390ca3390d40b92e5bb7575995e675a710c8958176ffbae47e15a3411L116This was most likely removed by mistake in an attempt to clean up as many style overrides as possible.