ocm: Check for ID provider match as well when creating shares #641
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating OCM shares, we need to take both the user ID as well as the provider ID as input, as the same user ID can be present across mesh providers, but the combination of the provider ID and user ID would be unique. I changed the logic for the JSON driver, but for ldap, there's a comment that says
this is screaming for errors if filter contains >1 %s
, tracked in #326. So that needs to be corrected.