Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocm: Check for ID provider match as well when creating shares #641

Merged
merged 1 commit into from
Apr 3, 2020

Conversation

ishank011
Copy link
Contributor

@ishank011 ishank011 commented Apr 3, 2020

When creating OCM shares, we need to take both the user ID as well as the provider ID as input, as the same user ID can be present across mesh providers, but the combination of the provider ID and user ID would be unique. I changed the logic for the JSON driver, but for ldap, there's a comment that says this is screaming for errors if filter contains >1 %s, tracked in #326. So that needs to be corrected.

@ishank011 ishank011 requested a review from labkode as a code owner April 3, 2020 12:02
@ishank011 ishank011 requested a review from butonic April 3, 2020 12:07
@labkode
Copy link
Member

labkode commented Apr 3, 2020

@ishank011 for OCM shares, you need to take as userID whatever is given by sharer OCM service when forwarding the invitation. The IdP and UserID sent by the remote OCM provider does not neccesary needs to exist on the receiving part, indeed, that will be the normal case.

@ishank011
Copy link
Contributor Author

@labkode Okay so are we sure that a user's ID, as provided by the sharer OCM service, would be unique across all the providers?

@labkode
Copy link
Member

labkode commented Apr 3, 2020

@ishank011 I got your question. You're right, the user id provided by the original sharer is only unique inside that system, for us, to be unique we need take in consideration the provider.

@ishank011 ishank011 changed the title ocm: Check for ID provider match as well when creating shares ocm: Check for provider ID match as well when creating shares Apr 3, 2020
@ishank011 ishank011 changed the title ocm: Check for provider ID match as well when creating shares ocm: Check for ID provider match as well when creating shares Apr 3, 2020
@ishank011 ishank011 force-pushed the ocm_share_add_provider branch from b4cf6e1 to 1ec6317 Compare April 3, 2020 14:29
@labkode labkode merged commit 9f5dd30 into cs3org:master Apr 3, 2020
@ishank011 ishank011 deleted the ocm_share_add_provider branch April 4, 2020 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants