Use manager to list shares #4971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hm the AcceptReceivedShare code also calls usershareprovider.GetMountpointAndUnmountedShares ... and calls UpdateReceivedShare .... which internally also calls GetMountpointAndUnmountedShares ... needs further investigation. |
butonic
force-pushed
the
usershareprovider-list-with-manager
branch
from
638da1a to
2808a6c
Compare
|
hm ... the whole ocs share manager is actually dead unused code .... but we cannot kill it because the reva tests still use them... |
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
butonic
force-pushed
the
usershareprovider-list-with-manager
branch
from
2808a6c to
86812e7
Compare
micbar
approved these changes
Nov 25, 2024
This was referenced Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When updating a received share the usershareprovider now uses the share manager directly to list received shares instead of going through the gateway again.
fixes owncloud/ocis#10646