Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate lock in PROPPATCH in WebDAV #4928

Merged
merged 5 commits into from
Nov 21, 2024
Merged

Conversation

roman-vanicek
Copy link

Description

Windows built-in WebDAV client in default configuration cannot copy/create files after mounting owncloud as a disk drive using net use D: ... This is one of two necessary changes to make it work.

Related Issue

  • another issue that otherwise blocks Windows WebDAV client is a name of the HTTP header that contains the lock value. In previous version of reva it used the HTTP header "If". The current version uses header "Lock-Token". I do not know the reason for this change so it is not part of this PR. Moreover this issue can be worked around on reverse proxy by duplicating the HTTP header value.

Motivation and Context

No Windows client can use WebDAV in the default configuration on ocis and Windows.

How Has This Been Tested?

Tested on my own ocis build that contains just this fix. No test case added.

@roman-vanicek roman-vanicek requested review from labkode and a team as code owners November 12, 2024 17:16
Copy link

update-docs bot commented Nov 12, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

Copy link
Contributor

@kobergj kobergj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Code looks good. But it needs a changelog in changelog/unreleased folder to get a green pipeline

Copy link
Contributor

@kobergj kobergj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @roman-vanicek 👍

@kobergj
Copy link
Contributor

kobergj commented Nov 18, 2024

@roman-vanicek somehow test are failing unrelated. Could you rebase to latest edge? Maybe that fixes it. (I tried doing it myself, but seems I cannot access your fork...)

@roman-vanicek
Copy link
Author

not much better now unfortunately

@micbar micbar merged commit 2041e81 into cs3org:edge Nov 21, 2024
10 checks passed
@micbar
Copy link
Member

micbar commented Nov 21, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants