Dont postprocess 0 byte files #4778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jkoberg <[email protected]>
kobergj
force-pushed
the
FixZeroByteUploads
branch
from
8e49ef6 to
1edd0c3
Compare
dragonchaser
approved these changes
Jul 25, 2024
This was referenced Jul 29, 2024
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tackles owncloud/ocis#9573
I can't reproduce this locally. But
decomposedfswill callFinishUploaddirectly if it is a 0 byte upload. https://github.com/cs3org/reva/blob/edge/pkg/storage/utils/decomposedfs/upload.go#L322-L328But it would still send a
BytesReceivedevent. This is wrong imho, because it didn't receive any bytes.Anyways I hope this also fixes the attached issue.