Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disallow reserved names #4740

Merged
merged 4 commits into from
Jul 3, 2024
Merged

Conversation

butonic
Copy link
Contributor

@butonic butonic commented Jun 25, 2024

We now disallow the reserved .. and . filenames. They are only allowed as destinations of move or copy operations.

supersedes #4721
refs owncloud/ocis#1002

@butonic butonic requested review from labkode, a team and glpatcern as code owners June 25, 2024 09:11
@butonic butonic requested review from dragonchaser and kobergj June 25, 2024 09:12
butonic added 2 commits June 25, 2024 12:17
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
@butonic butonic force-pushed the disallow-reserved-names branch from 70165ef to 24ca4f8 Compare June 25, 2024 10:18
@saw-jan
Copy link
Contributor

saw-jan commented Jun 25, 2024

      | dav-path-version | file-name | http-status-code |
      | old              | /.        | 500              |
        Failed step: Then the HTTP status code should be "500"
        HTTP status code 400 is not the expected value 500
        Failed asserting that 400 matches expected '500'.

need test adjustment in ocis. and for that we need this to be merged first and then reva bump in ocis

Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
@butonic butonic force-pushed the disallow-reserved-names branch from c857935 to 8e8efc8 Compare June 25, 2024 12:17
@dragonchaser dragonchaser force-pushed the disallow-reserved-names branch 3 times, most recently from 2dc2fe6 to 0e7facb Compare July 2, 2024 15:10
Signed-off-by: Christian Richter <[email protected]>
@dragonchaser dragonchaser force-pushed the disallow-reserved-names branch from 0e7facb to bef3818 Compare July 2, 2024 15:26
@dragonchaser dragonchaser merged commit d599d88 into cs3org:edge Jul 3, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants