configurable S3 PUT options #4526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
butonic
force-pushed
the
configurable-s3-put-options
branch
from
ecae2f9 to
e48a559
Compare
butonic
force-pushed
the
configurable-s3-put-options
branch
from
e48a559 to
02b2113
Compare
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
butonic
force-pushed
the
configurable-s3-put-options
branch
from
02b2113 to
1952b1d
Compare
dragonchaser
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The s3ng blobstore can now be configured with several options:
s3.disable_content_sha254,s3.disable_multipart,s3.send_content_md5,s3.concurrent_stream_parts,s3.num_threadsands3.part_size. If unset we default tos3.send_content_md5: true, which was hardcoded before. We also default tos3.concurrent_stream_parts: trueands3.num_threads: 4to allow concurrent uploads even whens3.send_content_md5is set totrue. When tweaking the uploads try settings3.send_content_md5: falseands3.concurrent_stream_parts: falsefirst, as this will try to concurrently stream an uploaded file to the s3 store without cutting it into parts first.