Allow authentication for nats connections #4412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2403905
approved these changes
Dec 15, 2023
Signed-off-by: jkoberg <[email protected]>
kobergj
force-pushed
the
AuthenticationForNats
branch
from
e97da3e to
24deebf
Compare
butonic
approved these changes
Dec 18, 2023
Comment on lines
237
to
238
| AuthUsername: m["username"].(string), | ||
| AuthPassword: m["password"].(string), |
There was a problem hiding this comment.
this is a little bit fragile ... if the config struct m does not have a key set this will panic with
"interface conversion: interface {} is nil, not string"
same for all the other keys, here ... still kinda meh.
There was a problem hiding this comment.
Good point 👍 I moved the definition to the source struct and use mapstructure.Decode to unmarshal it. Please double check.
kobergj
force-pushed
the
AuthenticationForNats
branch
from
24deebf to
78fd376
Compare
Signed-off-by: jkoberg <[email protected]>
kobergj
force-pushed
the
AuthenticationForNats
branch
from
78fd376 to
84e060e
Compare
butonic
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows authenticating nats connections with username/password