Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass default nats options #4214

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Conversation

butonic
Copy link
Contributor

@butonic butonic commented Sep 25, 2023

The nats option passed completely replace the default nats options, so we need to pass in adjusted default options.

@update-docs
Copy link

update-docs bot commented Sep 25, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@butonic
Copy link
Contributor Author

butonic commented Sep 25, 2023

fixes owncloud/ocis#7056 (comment)

@butonic butonic force-pushed the pass-default-nats-options branch from e17354d to 0b0243d Compare September 25, 2023 13:16
@butonic butonic requested review from glpatcern and a team as code owners September 25, 2023 13:16
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Copy link
Contributor

@kobergj kobergj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find 👍

@butonic
Copy link
Contributor Author

butonic commented Sep 25, 2023

verified this works in kubernetes as expected as per owncloud/ocis#7056 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants