Rollback migrations #4083
Merged
Rollback migrations #4083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduffeck
requested review from
a team,
labkode,
ishank011 and
glpatcern
as code owners
kobergj
requested changes
Jul 27, 2023
pkg/storage/utils/decomposedfs/migrator/0004_switch_to_messagepack_space_index.go
Outdated
Show resolved
Hide resolved
pkg/storage/utils/decomposedfs/migrator/0004_switch_to_messagepack_space_index.go
Outdated
Show resolved
Hide resolved
pkg/storage/utils/decomposedfs/migrator/0004_switch_to_messagepack_space_index.go
Outdated
Show resolved
Hide resolved
pkg/storage/utils/decomposedfs/migrator/0004_switch_to_messagepack_space_index.go
Outdated
Show resolved
Hide resolved
| @@ -30,7 +30,7 @@ import ( | |||
| ) | |||
|
|
|||
| // Migration0001 creates the spaces directory structure | |||
| func (m *Migrator) Migration0001() (Result, error) { | |||
| func (m *Migrator) Up0001() (Result, error) { | |||
There was a problem hiding this comment.
I like the old naming more. Can we go for MigrationXXXX and RollbackXXXX?
Comment on lines
121
to
122
| migrateMethod := reflect.ValueOf(m).MethodByName(method) | ||
| v := migrateMethod.Call(nil) |
There was a problem hiding this comment.
Can we avoid the reflect magic? I'd be more fine with a hardcoded list.
pkg/storage/utils/decomposedfs/migrator/0005_fix_messagepack_space_index_format.go
Outdated
Show resolved
Hide resolved
Co-authored-by: kobergj <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The decomposedfs now supports rolling back migrations (starting with 0004). It also got a Migrations() method which returns the list of migrations incl. their states.