Fix writing 0 byte msgpack metadata #4033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
aduffeck
force-pushed
the
fix-writing-0-byte-msgpack-metadata
branch
from
35d042a to
8d7ed4d
Compare
butonic
requested review from
a team,
labkode,
ishank011 and
glpatcern
as code owners
aduffeck
approved these changes
Jul 4, 2023
aduffeck
added a commit
to aduffeck/reva
that referenced
this pull request
Jul 4, 2023
* Prevent 0-byte metadata files * ignore reading not existing file Signed-off-by: Jörn Friedrich Dreyer <[email protected]> * actually, we are the ones creating empty files on purpose :( Signed-off-by: Jörn Friedrich Dreyer <[email protected]> * Lock the proper file * Do not tolerate existing 0-byte files. We do not generate them anymore * Only tolerate ErrNotExist errors * Fix rebase error * Handle error * Add changelog Signed-off-by: Jörn Friedrich Dreyer <[email protected]> * Adapt IsMetaFile to new locking strategy * always touch metadata file Signed-off-by: Jörn Friedrich Dreyer <[email protected]> * Fix unit tests * Do not try to read metadata from the lock file * Filter .lock files when listing revisions * Prevent lockfile name clashes --------- Signed-off-by: Jörn Friedrich Dreyer <[email protected]> Co-authored-by: André Duffeck <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry picks for the 0-byte msgpack file metadata fix from #4017