Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

En-/Disable DEPTH:inifinity in PROPFIND #4014

Merged
merged 6 commits into from
Jul 24, 2023

Conversation

dragonchaser
Copy link

@dragonchaser dragonchaser commented Jun 26, 2023

Enhancement: En-/Disable DEPTH:inifinity in PROPFIND

We have added the ability to en-/disable DEPTH:infinitiy in PROPFIND requests for spaces

owncloud/ocis#4188

@update-docs
Copy link

update-docs bot commented Jun 26, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@dragonchaser dragonchaser changed the base branch from master to edge June 26, 2023 14:24
@dragonchaser dragonchaser force-pushed the issue-4188-depth-infinity branch from e10f724 to 5b992e1 Compare June 26, 2023 14:24
@dragonchaser dragonchaser marked this pull request as ready for review June 26, 2023 14:37
@dragonchaser dragonchaser requested review from a team, labkode, ishank011 and glpatcern as code owners June 26, 2023 14:37
@micbar
Copy link
Member

micbar commented Jun 27, 2023

I was under the impression that this is a configurable option. Why do we disable it completely?

@dragonchaser dragonchaser marked this pull request as draft June 28, 2023 07:15
@dragonchaser dragonchaser force-pushed the issue-4188-depth-infinity branch from 60f06fb to 7ba8801 Compare June 28, 2023 11:51
@dragonchaser dragonchaser force-pushed the issue-4188-depth-infinity branch 4 times, most recently from e0905fb to 97bb298 Compare July 17, 2023 14:46
@dragonchaser dragonchaser changed the title Issue 4188 depth infinity En-/Disable DEPTH:inifinity in PROPFIND Jul 17, 2023
@dragonchaser dragonchaser marked this pull request as ready for review July 17, 2023 15:01
@dragonchaser dragonchaser marked this pull request as draft July 18, 2023 16:10
@dragonchaser
Copy link
Author

reverted to draft, this seems to be causeing a nil-pointer issue when testing with ocis details: owncloud/ocis#6842

@dragonchaser dragonchaser force-pushed the issue-4188-depth-infinity branch from 97bb298 to 62b87b6 Compare July 20, 2023 10:34
Signed-off-by: Christian Richter <[email protected]>
Signed-off-by: Christian Richter <[email protected]>
Signed-off-by: Christian Richter <[email protected]>
@dragonchaser dragonchaser force-pushed the issue-4188-depth-infinity branch from 62b87b6 to decf589 Compare July 21, 2023 09:24
Signed-off-by: Christian Richter <[email protected]>
@dragonchaser dragonchaser force-pushed the issue-4188-depth-infinity branch from 7c4b2f2 to 75f0f69 Compare July 24, 2023 13:12
@dragonchaser dragonchaser marked this pull request as ready for review July 24, 2023 13:24
@dragonchaser dragonchaser merged commit f4507ac into cs3org:edge Jul 24, 2023
@dragonchaser dragonchaser deleted the issue-4188-depth-infinity branch July 24, 2023 14:29
S-Panta pushed a commit to JankariTech/reva that referenced this pull request Aug 2, 2023
…inity

En-/Disable DEPTH:inifinity in PROPFIND
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants