decomposedfs: write metadata once #3816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
butonic
requested review from
a team,
labkode,
ishank011 and
glpatcern
as code owners
butonic
force-pushed
the
write-metadata-once
branch
from
c3f9125 to
41a3598
Compare
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
butonic
force-pushed
the
write-metadata-once
branch
from
41a3598 to
e2f81d9
Compare
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
butonic
commented
Apr 25, 2023
Comment on lines
-282
to
-285
|
|
||
| It("does not try to delete a blob from the blobstore", func() { | ||
| env.Blobstore.AssertNotCalled(GinkgoT(), "Delete", mock.AnythingOfType("*node.Node")) | ||
| }) |
There was a problem hiding this comment.
hm ... were we testing a bug? Or was there a reason for asserting NO delete?
86 tasks
2403905
pushed a commit
to 2403905/reva
that referenced
this pull request
May 19, 2023
* decomposedfs: write metadata once Signed-off-by: Jörn Friedrich Dreyer <[email protected]> * only try reading blobsize for files Signed-off-by: Jörn Friedrich Dreyer <[email protected]> * Fix tests --------- Signed-off-by: Jörn Friedrich Dreyer <[email protected]> Co-authored-by: André Duffeck <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
decomposedfs now aggregates metadata when creating directories and spaces into a single write.