Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public Links #381

Merged
merged 19 commits into from
Mar 24, 2020
Merged

Public Links #381

merged 19 commits into from
Mar 24, 2020

Conversation

refs
Copy link
Member

@refs refs commented Nov 20, 2019

What?

DAV Api for public shares. Currently displaying public shares depends on owncloud/web#2494.

Is there a way to access a resource in behalf of the resource owner that is not through basic auth?

  • show user shares and public shares on the sidebar
  • reachable publicShare handler
  • whitelist public share urls (in order to access a public share)

@refs refs requested a review from labkode as a code owner November 20, 2019 14:29
@labkode
Copy link
Member

labkode commented Feb 25, 2020

@refs we need to rebase this on master

@refs
Copy link
Member Author

refs commented Feb 26, 2020

@labkode Indeed we need to rebase master onto this branch. I tried to update it every once in a while, will do ASAP.

Next week I'm spending time on Reva, so will resume this from next week on! Been busy with the extensions.

@labkode
Copy link
Member

labkode commented Feb 26, 2020

@refs glad to hear that :)

@refs
Copy link
Member Author

refs commented Mar 2, 2020

@labkode branch updated, resuming work on this now :)

@labkode
Copy link
Member

labkode commented Mar 11, 2020

@refs is this still WIP or ready to merge?

@refs
Copy link
Member Author

refs commented Mar 12, 2020

@refs is this still WIP or ready to merge?

Still WIP. Getting up to speed on Reva :)

@refs refs changed the title [WIP] Public Links Public Links Mar 23, 2020
@butonic
Copy link
Contributor

butonic commented Mar 23, 2020

🚀 creating link works!

@refs
Copy link
Member Author

refs commented Mar 24, 2020

cc @labkode we still need to figure out a few bits and , but creating public links works. This is ready to be merged.

@labkode labkode merged commit 450fb36 into cs3org:master Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants