-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize file metadata #3697
Optimize file metadata #3697
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
b1a9658
to
46a5d3d
Compare
p.ParentID, _ = p.Xattr(prefixes.ParentidAttr) | ||
p.Name, _ = p.Xattr(prefixes.NameAttr) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why can we ignore an error here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
renaming the xattrs package to metadata and adding the Metadata interface to PathLookup makes sense. I see how you are sneaking in a Metadata backend into the Node. ;-)
Still needs some hoops for the revisions and trash, but this is a step forward. ❤️
Locks are either handled by the backend or given from external now.
The sentinel configuration is given in the cache node in the following form: <host>/<name of master> e.g. 10.10.0.207/mymaster
This allows for using different backends for different filesystems in the same process.
5a53efd
to
c680d50
Compare
This PR improves the ini backend for file metadata:
tremendously when using distributed file systems, for example
We also switched the s3ng integration tests to the ini backend so we cover both the xattrs and the ini backend at the same time.
Finally it adds support for redis sentinel caches (owncloud/ocis#5645)