[tests-only] [full-ci] Run API tests from ocis repo (master)

[phil-davis]

1. Bump CORE_COMMITID for API tests (get it up-to-date and passing first
2. run the API tests out of the owncloud/ocis repo

The API test code and feature files was moved to owncloud/ocis in PR owncloud/ocis#5280

The original API test code in owncloud/core will no longer be guaranteed to support reva/ocis special settings etc. So we will be better to run the API test code that is in owncloud/ocis

Note: this has also been done in edge PR #3591

[saw-jan]

Need to bring back --remote related code in the run.sh

[phil-davis]

Need to bring back --remote related code in the run.sh

Hmmm - this stuff passed in reva edge branch, which has --remote mentioned in Makefile. I suppose that it is ignored (does nothing special any more), but it passes anyway.

I pushed a commit to remove --remote here, just to see what happens. I suspect that it will still fail.

[phil-davis]

I pushed a commit to remove --remote here, just to see what happens. I suspect that it will still fail.

It passed. That's good :)

For future reference, the failing pipeline was https://drone.owncloud.com/cs3org/reva/173/3/5

BEHAT_BIN=vendor-bin/behat/vendor/bin/behat /drone/src/tmp/testrunner/tests/acceptance/run.sh --remote --type api
Script path: /drone/src/tmp/testrunner/tests/acceptance
basename: unrecognized option '--remote'
Try 'basename --help' for more information.
Running apiVirtualViews tests tagged @api&&~@skip
Using behat config 'tests/acceptance/config/behat.yml'

In ArgvInput.php line 220:
                                                        
  [Symfony\Component\Console\Exception\RuntimeException]  
  The "--remote" option does not exist.                   

run.sh no longer needs or processes the --remote option. The option does not get removed during the processing of the command line, and ends being "accidentally" used as an option to basename at some point in the script. That explodes, of course.

--remote used to "tell" the test scripts that the system-under-test is really "remote', meaning that the backend of the system-under-test is not accessible by the front-end test code. Taht is, the test code cannot "cheat" and try to look locally for uploaded files to "appear" in the backend of the file-system of the system-under-test. And the test code cannot expect to have a "testing" app available on the system-under-test. Now that we have moved the test code to the ocis repo, the test code always behaves as --remote - we only use the test code to test ocis or reva. So we stop specifying --remote

[phil-davis]

@labkode @glpatcern @gmgigi96 I have touched some file that needs special approval (maybe Makefile is the one)

Please review/approve/merge.

[phil-davis]

@labkode @glpatcern @gmgigi96 ping

[phil-davis]

@labkode @glpatcern @gmgigi96 ping again - please review/approve/merge.

[glpatcern]

Apologies for the delay, we reviewed this with @vascoguita as we are also evolving the CI. Hopefully if we get drone fully functional as well we should be all good.

[phil-davis]

Note: this change did not change the tests that are run, or how many pipelines are run etc.
It just changed the source of the test scenarios and test code, because we moved all that into the owncloud/ocis repository.

[vascoguita]

@phil-davis Is it possible to use only owncloud/ocis?
I see that the virtualViews test uses owncloud/ocis now but s3ngIntegrationTests and the ocisIntegrationTests are still using owncloud/core.

[phil-davis]

Is it possible to use only owncloud/ocis?

I am not sure what you mean. .drone.star cloneApiTestReposStep()` has:

"git clone -b $APITESTS_BRANCH --single-branch --no-tags https://github.com/owncloud/ocis.git /drone/src/tmp/testrunner",

The feature files and test code are cloned from owncloud/ocis for all the acceptance test pipelines.

[vascoguita]

Indeed, everything moved to owncloud/ocis. Please ignore my comment