Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce otel tracing #3496

Merged
merged 5 commits into from
May 26, 2023
Merged

introduce otel tracing #3496

merged 5 commits into from
May 26, 2023

Conversation

butonic
Copy link
Contributor

@butonic butonic commented Nov 25, 2022

I was toying with https://github.com/SigNoz/signoz which uses otel tracing. This PR allows configuring tracing_exporter=otlp as a trace exporter.

@butonic butonic requested review from a team, labkode and ishank011 as code owners November 25, 2022 15:41
@update-docs
Copy link

update-docs bot commented Nov 25, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@butonic butonic requested a review from glpatcern as a code owner November 25, 2022 15:42
@butonic butonic marked this pull request as draft November 25, 2022 15:43
@butonic butonic self-assigned this Nov 25, 2022
@butonic butonic force-pushed the otel-tracing branch 2 times, most recently from 69c0dff to db807c5 Compare December 6, 2022 11:47
@butonic butonic force-pushed the otel-tracing branch 2 times, most recently from cded423 to 05466a3 Compare February 13, 2023 15:19
pkg/trace/trace.go Outdated Show resolved Hide resolved
@Excds
Copy link

Excds commented May 25, 2023

LGTM (except for the commented out section).

butonic and others added 4 commits May 25, 2023 14:18
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>

introduce otlp tracing

Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
@aduffeck aduffeck marked this pull request as ready for review May 25, 2023 12:18
Copy link
Contributor

@fschade fschade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@butonic butonic merged commit d62d149 into cs3org:edge May 26, 2023
@butonic butonic deleted the otel-tracing branch May 26, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants