-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
introduce otel tracing #3496
Merged
Merged
introduce otel tracing #3496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
butonic
force-pushed
the
otel-tracing
branch
from
November 25, 2022 15:43
f51ba1c
to
8ae2afc
Compare
butonic
force-pushed
the
otel-tracing
branch
2 times, most recently
from
December 6, 2022 11:47
69c0dff
to
db807c5
Compare
butonic
force-pushed
the
otel-tracing
branch
2 times, most recently
from
February 13, 2023 15:19
cded423
to
05466a3
Compare
11 tasks
Excds
suggested changes
May 25, 2023
LGTM (except for the commented out section). |
aduffeck
approved these changes
May 25, 2023
Signed-off-by: Jörn Friedrich Dreyer <[email protected]> introduce otlp tracing Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
fschade
approved these changes
May 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
86 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was toying with https://github.com/SigNoz/signoz which uses otel tracing. This PR allows configuring
tracing_exporter=otlp
as a trace exporter.