Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build-deps] prepare release, bump version #3431

Merged
merged 8 commits into from
Nov 4, 2022
Merged

[build-deps] prepare release, bump version #3431

merged 8 commits into from
Nov 4, 2022

Conversation

micbar
Copy link
Member

@micbar micbar commented Nov 3, 2022

Description

  • bump version
  • Run CI
  • tag
  • merge after successful CI run

micbar and others added 3 commits November 3, 2022 16:45
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
@butonic
Copy link
Contributor

butonic commented Nov 3, 2022

@fschade @kobergj we seem to have introduced a new flaky test

=== RUN   TestAcquireWriteLock
--
1394 | filelocks_test.go:39:
1395 | Error Trace:	/drone/src/pkg/storage/utils/filelocks/filelocks_test.go:39
1396 | /drone/src/pkg/storage/utils/filelocks/asm_amd64.s:1571
1397 | Error:      	Expected nil, but got: &errors.errorString{s:"unable to acquire a lock on the file"}
1398 | Test:       	TestAcquireWriteLock
1399 | require.go:367:
1400 | Error Trace:	/drone/src/pkg/storage/utils/filelocks/filelocks_test.go:40
1401 | /drone/src/pkg/storage/utils/filelocks/asm_amd64.s:1571
1402 | Error:      	Expected value not to be nil.
1403 | Test:       	TestAcquireWriteLock
1404 | filelocks_test.go:39:
1405 | Error Trace:	/drone/src/pkg/storage/utils/filelocks/filelocks_test.go:39
1406 | /drone/src/pkg/storage/utils/filelocks/asm_amd64.s:1571
1407 | Error:      	Expected nil, but got: &errors.errorString{s:"unable to acquire a lock on the file"}
1408 | Test:       	TestAcquireWriteLock
1409 | require.go:367:
1410 | Error Trace:	/drone/src/pkg/storage/utils/filelocks/filelocks_test.go:40
1411 | /drone/src/pkg/storage/utils/filelocks/asm_amd64.s:1571
1412 | Error:      	Expected value not to be nil.
1413 | Test:       	TestAcquireWriteLock
1414 | coverage: 86.0% of statements
1415 | panic: test timed out after 10m0s
1416 |  
1417 | goroutine 3 [running]:
1418 | testing.(*M).startAlarm.func1()
1419 | /usr/local/go/src/testing/testing.go:2029 +0xbb
1420 | created by time.goFunc
1421 | /usr/local/go/src/time/sleep.go:176 +0x48
1422 |  
1423 | goroutine 1 [chan receive]:
1424 | testing.(*T).Run(0xc000196340, {0x6caccc, 0x14}, 0x6da800)
1425 | /usr/local/go/src/testing/testing.go:1487 +0x750
1426 | testing.runTests.func1(0x0?)
1427 | /usr/local/go/src/testing/testing.go:1839 +0x9a
1428 | testing.tRunner(0xc000196340, 0xc000169b68)
1429 | /usr/local/go/src/testing/testing.go:1439 +0x214
1430 | testing.runTests(0xc0001450e0?, {0x85ff40, 0x4, 0x4}, {0x40?, 0x7f6da9040f70?, 0x8666c0?})
1431 | /usr/local/go/src/testing/testing.go:1837 +0x7e5
1432 | testing.(*M).Run(0xc0001450e0)
1433 | /usr/local/go/src/testing/testing.go:1719 +0xa72
1434 | main.main()
1435 | _testmain.go:103 +0x3aa
1436 |  
1437 | goroutine 34 [semacquire]:
1438 | sync.runtime_Semacquire(0xc000204068?)
1439 | /usr/local/go/src/runtime/sema.go:56 +0x25
1440 | sync.(*WaitGroup).Wait(0xc000204060)
1441 | /usr/local/go/src/sync/waitgroup.go:136 +0x9c
1442 | github.com/cs3org/reva/v2/pkg/storage/utils/filelocks_test.TestAcquireWriteLock(0xc000212000)
1443 | /drone/src/pkg/storage/utils/filelocks/filelocks_test.go:51 +0x1fa
1444 | testing.tRunner(0xc000212000, 0x6da800)
1445 | /usr/local/go/src/testing/testing.go:1439 +0x214
1446 | created by testing.(*T).Run
1447 | /usr/local/go/src/testing/testing.go:1486 +0x725
1448 | FAIL	github.com/cs3org/reva/v2/pkg/storage/utils/filelocks	600.215s

@butonic butonic merged commit 08e8e82 into edge Nov 4, 2022
@micbar micbar deleted the release-2.11.0 branch November 4, 2022 07:32
@fschade
Copy link
Contributor

fschade commented Nov 4, 2022

@butonic yes, we have to tweak the timing in tests. I prepare a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants