Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public share json persistence #3199

Merged
merged 11 commits into from
Sep 9, 2022

Conversation

butonic
Copy link
Contributor

@butonic butonic commented Sep 7, 2022

introduce different persistence implementations for the public json share manager

  • memory
  • file
  • cs3
  • cache

Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
@update-docs
Copy link

update-docs bot commented Sep 7, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@lgtm-com
Copy link

lgtm-com bot commented Sep 7, 2022

This pull request introduces 1 alert when merging f40fe0e into 53b778d - view on LGTM.com

new alerts:

  • 1 for Useless assignment to field

@aduffeck aduffeck force-pushed the public-share-json-persistence branch 2 times, most recently from 906e5e0 to aa86f6b Compare September 8, 2022 11:30
@butonic butonic marked this pull request as ready for review September 9, 2022 09:50
@butonic butonic requested review from labkode, ishank011, glpatcern and a team as code owners September 9, 2022 09:50
@aduffeck aduffeck force-pushed the public-share-json-persistence branch from aa86f6b to 2a1ac07 Compare September 9, 2022 09:53
@butonic butonic requested review from aduffeck and micbar September 9, 2022 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants