Add permission checks on homespace delete #3180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Ralf Haferkamp <[email protected]>
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
Co-authored-by: Ralf Haferkamp <[email protected]>
dragonchaser
force-pushed
the
add-permission-checks
branch
from
63f88e6 to
17d3dc5
Compare
Signed-off-by: Christian Richter <[email protected]>
dragonchaser
force-pushed
the
add-permission-checks
branch
from
17d3dc5 to
6a33832
Compare
dragonchaser
requested review from
a team,
labkode,
ishank011 and
glpatcern
as code owners
C0rby
approved these changes
Sep 2, 2022
29 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds permission checks to the DeleteStorageSpace function, in case the user tries to delete a homespace.
refs owncloud/ocis#4447
refs owncloud/ocis#4195