-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
non personal spaces need no owner #3091
Conversation
5c1fe2b
to
d38592a
Compare
I like the concept, however, naming is hard. I don't think this is a 'virtual' user. Conceptually, it represents no user, aka nobody in unix ... well ... in unix nobody should never 'own' any files or folders ... |
After checking the public link auth, this needs another approach. |
f1514eb
to
6ab8cd4
Compare
Solution approachPublic links will become the new unified links. Therefore they will have a longer lifecycle than public links. This PR assigns an owner with the spaceID as UserID and type @C0rby JFYI |
3e79826
to
d3797f0
Compare
4f9f9f4
to
063b4f0
Compare
While I am not happy with using an invalid user type, we can update the CS3 api with a new |
@butonic done |
Description
Project spaces should not have a real user as an owner.
That fixes the bug when the space creator leaves the space and is no longer granted access to the space.
@butonic @kobergj @dragotin
Solution approach
Public links will become the new unified links. Therefore they will have a longer lifecycle than public links.
Inside a space, we need a stable way to access a public link regardless of the users which can join or leave the space at any time.
This PR assigns an owner with the spaceID as UserID and type
invalid
as a space owner. In this way, the public link scoped token authentication can work in the same way like inside of a personal space.@C0rby JFYI