-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make dataprovider send headers #3080
Conversation
dd53252
to
680649a
Compare
@butonic what about encapsulating all this information into a JSON structure and pass that payload into one single header that can be decoded in a simpler way compared to have the information spread across multiple headers? |
@labkode most of the headers are standard headers: ContentType, ContentDisposition, ETag and LastModified. Which leaves the OC prefixed headers:
The next question then becomes how can clients request what metadata to return, eg by providing a field mask in the get request ... again, as a header. |
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
related owncloud/ocis#3782 |
Instead of ocdav doing an additional Stat request we now rely on the dataprovider to return the necessary metadata information as headers. As a bonus it prevents race conditions between the Stat and InitiateFileDownload calls.
related: owncloud/ocis#4153