ench: use functional options for client gRPC connections #2801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amalthundiyil
requested review from
labkode,
ishank011,
glpatcern,
a team and
wkloucek
as code owners
amalthundiyil
force-pushed
the
grpc-client-options
branch
2 times, most recently
from
d1939d0 to
298735b
Compare
amalthundiyil
force-pushed
the
grpc-client-options
branch
from
298735b to
676ce94
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
ishank011
approved these changes
May 3, 2022
|
@amal-thundiyil have you considered submitting this work as part of https://gohack.devpost.com/details/cerntrack#h_7413309046481645659684425 hackathon? |
Thank you for the suggestion @labkode. I will definitely consider it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored and introduced functional options to
pkg/pool. This will aid more flexible configuration for the client side gRPC connections.