Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fake ProviderIDs #2790

Merged
merged 18 commits into from
Apr 28, 2022
Merged

Fake ProviderIDs #2790

merged 18 commits into from
Apr 28, 2022

Conversation

kobergj
Copy link
Contributor

@kobergj kobergj commented Apr 28, 2022

Adds providerids to the storageproviders. These have no function so far, but are needed for the static registry

kobergj and others added 14 commits April 28, 2022 10:50
@kobergj
get rid of interceptor and move logic to storageprovider
196f80b 
Signed-off-by: jkoberg <[email protected]>
@kobergj
use configured mountID instead of requested one
784dca3 
Signed-off-by: jkoberg <[email protected]>
@kobergj
use requested providerID for Stat calls
68e490d 
Signed-off-by: jkoberg <[email protected]>
@kobergj
storageid unwrap for sharesstorageprovider
53dbba9 
Signed-off-by: jkoberg <[email protected]>
@kobergj
storageid unwrap for publicstorageprovider
0b673f5 
Signed-off-by: jkoberg <[email protected]>
@kobergj
fallback to providerid if empty
ee981cc 
Signed-off-by: jkoberg <[email protected]>
@kobergj
add mountid config for storage providers
dc44e02 
Signed-off-by: jkoberg <[email protected]>
@kobergj
add storageid unwrap functionality
d375e2f 
Signed-off-by: jkoberg <[email protected]>
@kobergj
changelog
fffba1a 
Signed-off-by: jkoberg <[email protected]>
@butonic
fix listing trash
895685f 
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
@kobergj
cut providerid from opaqueid
acd7803 
Signed-off-by: jkoberg <[email protected]>
@kobergj
fix import cycle in resourceid unit tests
2110b7f 
Signed-off-by: jkoberg <[email protected]>
@butonic
fix restore recycle item
badd7ed 
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
@kobergj
use feature core
764917c 
Signed-off-by: jkoberg <[email protected]>
@butonic butonic mentioned this pull request Apr 28, 2022
Merged
micbar
micbar approved these changes Apr 28, 2022
View reviewed changes
Copy link
Member

@micbar micbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

butonic and others added 4 commits April 28, 2022 13:57
@butonic
add missing share_with_user_type in share data
19b6d77 
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
@butonic
prevent panic
6692a3a 
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
@kobergj
bump core commit id
d2e4852 
Signed-off-by: jkoberg <[email protected]>
@kobergj
use feature core
6bc3f58 
Signed-off-by: jkoberg <[email protected]>
@butonic butonic marked this pull request as ready for review April 28, 2022 14:34
@butonic butonic requested review from a team, labkode, ishank011 and glpatcern as code owners April 28, 2022 14:34
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@butonic butonic merged commit 753492b into cs3org:edge Apr 28, 2022
This was referenced Apr 28, 2022
Merged
Closed
@butonic butonic mentioned this pull request Apr 28, 2022
Merged
1 task
@micbar micbar mentioned this pull request Apr 29, 2022
Merged
11 tasks
@kobergj kobergj mentioned this pull request May 3, 2022
Closed
@micbar micbar mentioned this pull request May 5, 2022
Closed
45 tasks
@kobergj kobergj mentioned this pull request Oct 14, 2022
Merged
@kiranparajuli589 kiranparajuli589 mentioned this pull request Oct 20, 2022
Merged
@kiranparajuli589 kiranparajuli589 mentioned this pull request Oct 28, 2022
Merged
@kobergj kobergj mentioned this pull request Dec 19, 2022
Merged
@kobergj kobergj mentioned this pull request May 22, 2023
Closed
@kobergj kobergj mentioned this pull request Mar 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micbar micbar micbar approved these changes

@labkode labkode Awaiting requested review from labkode labkode is a code owner

@ishank011 ishank011 Awaiting requested review from ishank011

@glpatcern glpatcern Awaiting requested review from glpatcern glpatcern is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kobergj @micbar @butonic