Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

in memory user provider #2781

Merged
merged 4 commits into from
Apr 27, 2022
Merged

in memory user provider #2781

merged 4 commits into from
Apr 27, 2022

Conversation

butonic
Copy link
Contributor

@butonic butonic commented Apr 25, 2022 •
edited
Loading

We added an in memory implementation for the user provider that reads the users from the mapstructure passed in.

We will use it to configure a second minimal gateway with a single system user for the metadata storage to keep it completely independent of the normal users.

See owncloud/ocis#3343

@butonic
in memory user and auth provider
b4c6a8a 
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
@butonic butonic requested review from labkode, ishank011, glpatcern and a team as code owners April 25, 2022 15:02
@butonic butonic requested a review from rhafer April 25, 2022 15:10
rhafer
rhafer reviewed Apr 26, 2022
View reviewed changes
Copy link
Contributor

@rhafer rhafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me overall. I just wonder, didn't we agree to just use the a separate instance of the machine auth provider for auth. That way we would just need the new userprovider. I might be mixing things up though.

pkg/auth/manager/memory/memory.go Outdated Show resolved Hide resolved
pkg/auth/manager/memory/memory.go Outdated Show resolved Hide resolved
butonic added 2 commits April 27, 2022 14:18
@butonic
add get by userid claim support to memory and demo
9d02a1e 
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
@butonic
get rid of in memory auth provider
98c01c3 
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
@butonic butonic changed the title in memory user and auth provider in memory user provider Apr 27, 2022
@butonic
update changelog
eb451a1 
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
@butonic butonic requested review from rhafer and C0rby April 27, 2022 14:21
@butonic butonic mentioned this pull request Apr 27, 2022
Merged
C0rby
C0rby approved these changes Apr 27, 2022
View reviewed changes
Copy link
Contributor

@C0rby C0rby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@butonic butonic merged commit bfdfc83 into cs3org:edge Apr 27, 2022
@butonic butonic deleted the user-provider-memory branch April 27, 2022 15:43
@micbar micbar mentioned this pull request May 5, 2022
Closed
45 tasks
@kobergj kobergj mentioned this pull request Oct 14, 2022
Merged
@kiranparajuli589 kiranparajuli589 mentioned this pull request Oct 20, 2022
Merged
@kiranparajuli589 kiranparajuli589 mentioned this pull request Oct 28, 2022
Merged
@kobergj kobergj mentioned this pull request Dec 19, 2022
Merged
@kobergj kobergj mentioned this pull request May 22, 2023
Closed
@kobergj kobergj mentioned this pull request Mar 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@C0rby C0rby C0rby approved these changes

@labkode labkode Awaiting requested review from labkode labkode is a code owner

@ishank011 ishank011 Awaiting requested review from ishank011

@glpatcern glpatcern Awaiting requested review from glpatcern glpatcern is a code owner

@rhafer rhafer Awaiting requested review from rhafer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@butonic @rhafer @C0rby