Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci]Bump core commit id for tests #2722

Merged
merged 5 commits into from
Apr 21, 2022
Merged

[tests-only][full-ci]Bump core commit id for tests #2722

merged 5 commits into from
Apr 21, 2022

Conversation

SagarGi
Copy link
Contributor

@SagarGi SagarGi commented Apr 8, 2022 •
edited
Loading

Part of: owncloud/QA#736

This PR also include the following changes to remove jarnaiz/behat-junit-formatter as
Part of: owncloud/QA#737

@SagarGi SagarGi requested review from labkode, ishank011, glpatcern and a team as code owners April 8, 2022 07:42
@SagarGi SagarGi mentioned this pull request Apr 8, 2022
Closed
14 tasks
@phil-davis phil-davis self-requested a review April 8, 2022 08:06
@phil-davis
Copy link
Contributor

@SagarGi please also remove jarnaiz/behat-junit-formatter for issue owncloud/QA#737
It is just deleting references the same as in, for example, owncloud/search_elastic#279

Also do the same for edge branch.

@SagarGi SagarGi force-pushed the bump-core-commitid-to-reva-master branch from e43ebf4 to 9b0e914 Compare April 8, 2022 08:37
@SagarGi
Copy link
Contributor Author

SagarGi commented Apr 8, 2022

@SagarGi please also remove jarnaiz/behat-junit-formatter for issue owncloud/QA#737 It is just deleting references the same as in, for example, owncloud/search_elastic#279

Also do the same for edge branch.

@phil-davis sure.

@SagarGi SagarGi force-pushed the bump-core-commitid-to-reva-master branch from aec087e to e8bc9b2 Compare April 8, 2022 09:46
phil-davis
phil-davis previously approved these changes Apr 10, 2022
View reviewed changes
@phil-davis
Copy link
Contributor

@labkode @ishank011 @glpatcern the changes here are all test-related, but enough that GitHub does not let me merge. Please review/approve/merge. Thanks.

individual-it
individual-it previously approved these changes Apr 12, 2022
View reviewed changes
@phil-davis
Copy link
Contributor

@labkode @ishank011 @glpatcern PR has been updated for the latest core test changes. GitHub does not let me merge. Please review/approve/merge. Thanks.

glpatcern
glpatcern previously approved these changes Apr 13, 2022
View reviewed changes
@glpatcern
Copy link
Member

As expected my power is not enough, will probably need to review the CODEOWNERS. For now, @ishank011 can you please merge?

@SwikritiT SwikritiT dismissed stale reviews from glpatcern and individual-it via 0a9fb57 April 20, 2022 06:06
@SwikritiT SwikritiT force-pushed the bump-core-commitid-to-reva-master branch from 4a8ab50 to 0a9fb57 Compare April 20, 2022 06:06
@SwikritiT SwikritiT force-pushed the bump-core-commitid-to-reva-master branch from 448a886 to ac9133f Compare April 20, 2022 08:05
@phil-davis phil-davis self-requested a review April 20, 2022 08:20
@phil-davis
Copy link
Contributor

@labkode or @ishank011 - this has been updated again and is passing against the latest core acceptance tests.
Please review and merge.

@kiranparajuli589 kiranparajuli589 mentioned this pull request Apr 21, 2022
Closed
4 tasks
@phil-davis
Copy link
Contributor

@labkode or @ishank011 we are stuck - can you please take 1 minute to press approve and merge?

@ishank011 ishank011 merged commit f54756c into cs3org:master Apr 21, 2022
@phil-davis phil-davis deleted the bump-core-commitid-to-reva-master branch April 21, 2022 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishank011 ishank011 ishank011 approved these changes

@phil-davis phil-davis phil-davis approved these changes

@glpatcern glpatcern glpatcern left review comments

@individual-it individual-it individual-it left review comments

@labkode labkode Awaiting requested review from labkode

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@SagarGi @phil-davis @glpatcern @individual-it @ishank011 @SwikritiT