Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decomposed FS precondition failed locking #2709

Merged
merged 3 commits into from
Apr 1, 2022
Merged

Decomposed FS precondition failed locking #2709

merged 3 commits into from
Apr 1, 2022

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented Apr 1, 2022

We've fixed the return code from permission denied to precondition failed if a
user tries to lock an already locked file.

fixes owncloud/ocis#3434

@wkloucek wkloucek requested review from a team, labkode, ishank011 and glpatcern as code owners April 1, 2022 10:02
@wkloucek wkloucek requested a review from kobergj April 1, 2022 11:10
@wkloucek
Copy link
Contributor Author

wkloucek commented Apr 1, 2022

@kobergj I had to change the logic to ensure the right return code when a file was already locked. Therefore I again requested a review

@wkloucek wkloucek marked this pull request as draft April 1, 2022 12:02
@wkloucek wkloucek marked this pull request as ready for review April 1, 2022 13:51
@wkloucek wkloucek requested review from aduffeck and C0rby and removed request for labkode, glpatcern and ishank011 April 1, 2022 13:51
Copy link
Contributor

@kobergj kobergj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tricky solution 😄 Bit works for me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants