Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] install mockery with bingo #2671

Merged
merged 2 commits into from
Mar 31, 2022
Merged

[tests-only] install mockery with bingo #2671

merged 2 commits into from
Mar 31, 2022

Conversation

wkloucek
Copy link
Contributor

  • use bingo to version mockery
  • run a go generate step in CI to ensure that generated code is up do date / not manually changed

(manual cherry pick of mockery changes from #2407)

@wkloucek wkloucek requested review from a team, labkode and ishank011 as code owners March 25, 2022 06:51
@wkloucek wkloucek requested review from butonic, C0rby and kobergj and removed request for a team, labkode and ishank011 March 25, 2022 06:52
@wkloucek wkloucek mentioned this pull request Mar 25, 2022
Closed
@wkloucek wkloucek requested a review from micbar March 28, 2022 11:31
@wkloucek
Copy link
Contributor Author

Codacy complains about the formatting of the markdown - but it's autogenerated and would needed to be fixed on upstream bingo 🤷‍♂️

@wkloucek wkloucek merged commit a7e7a7e into cs3org:edge Mar 31, 2022
@wkloucek wkloucek deleted the bingo-mockery branch March 31, 2022 06:01
@kobergj kobergj mentioned this pull request Oct 14, 2022
Merged
@kiranparajuli589 kiranparajuli589 mentioned this pull request Oct 20, 2022
Merged
@kiranparajuli589 kiranparajuli589 mentioned this pull request Oct 28, 2022
Merged
@kobergj kobergj mentioned this pull request Dec 19, 2022
Merged
@kobergj kobergj mentioned this pull request May 22, 2023
Closed
@kobergj kobergj mentioned this pull request Mar 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kobergj kobergj kobergj approved these changes

@butonic butonic Awaiting requested review from butonic

@C0rby C0rby Awaiting requested review from C0rby

@micbar micbar Awaiting requested review from micbar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wkloucek @kobergj