add a spaceid to the propfind response #2657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C0rby
requested review from
a team,
labkode,
ishank011 and
glpatcern
as code owners
micbar
reviewed
Mar 21, 2022
|
|
||
| // when allprops has been requested | ||
| if pf.Allprop != nil { | ||
| // return all known properties | ||
| response.Propstat = append(response.Propstat, propfind.PropstatXML{ | ||
| propstatOK := propfind.PropstatXML{ |
|
What's the reasoning for naming the property |
|
🤷♂️ I implemented what was discussed in the linked issue. The storages in the backend are also called spaces so spaceid is technically correct. Storageid would be more generic though. I don't have a preference for either. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the spaceid to propfind responses so that clients have the necessary data to send subsequent requests.
See: owncloud/ocis#3345