Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

emit linkaccessfailed event when share is nil #2643

Merged
merged 1 commit into from
Mar 17, 2022
Merged

emit linkaccessfailed event when share is nil #2643

merged 1 commit into from
Mar 17, 2022

Conversation

butonic
Copy link
Contributor

@butonic butonic commented Mar 17, 2022

The code no longer panics when a link access failed event has no share.

@butonic butonic requested review from labkode, ishank011, glpatcern and a team as code owners March 17, 2022 08:06
@butonic butonic requested a review from kobergj March 17, 2022 08:06
kobergj
kobergj approved these changes Mar 17, 2022
View reviewed changes
Copy link
Contributor

@kobergj kobergj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Good find, Thanks!

@butonic butonic merged commit 701b083 into cs3org:edge Mar 17, 2022
@butonic butonic deleted the make-linkaccessfailed-more-robust branch March 17, 2022 08:47
@micbar micbar mentioned this pull request Mar 29, 2022
Closed
22 tasks
@kobergj kobergj mentioned this pull request Oct 14, 2022
Merged
@kiranparajuli589 kiranparajuli589 mentioned this pull request Oct 20, 2022
Merged
@kiranparajuli589 kiranparajuli589 mentioned this pull request Oct 28, 2022
Merged
@kobergj kobergj mentioned this pull request Dec 19, 2022
Merged
@kobergj kobergj mentioned this pull request May 22, 2023
Closed
@kobergj kobergj mentioned this pull request Mar 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kobergj kobergj kobergj approved these changes

@labkode labkode Awaiting requested review from labkode labkode is a code owner

@ishank011 ishank011 Awaiting requested review from ishank011

@glpatcern glpatcern Awaiting requested review from glpatcern glpatcern is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@butonic @kobergj