remove the base64 encoding of fileIDs #2559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micbar
requested review from
a team,
labkode,
ishank011 and
glpatcern
as code owners
|
@labkode @ishank011 I think this is an important backport from the |
phil-davis
approved these changes
Feb 17, 2022
There was a problem hiding this comment.
LGTM
There are no changes to https://github.com/cs3org/reva/blob/master/pkg/storage/utils/decomposedfs/spaces.go
I guess those changes in edge branch are not relevant here in master?
Yes, correct. |
butonic
approved these changes
Feb 17, 2022
|
@ishank011 @labkode This could break your bookmarked URLs of the bookmarks and the ID lookup of the app provider. You decide, if you need this in |
ishank011
approved these changes
Feb 17, 2022
45 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport of #2542