Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] Break test fix getPersonalSpaceIdForUser #2553

Closed
wants to merge 3 commits into from
Closed

[tests-only] Break test fix getPersonalSpaceIdForUser #2553

wants to merge 3 commits into from

Conversation

phil-davis
Copy link
Contributor

This is PR #2552 but with the idDelimiter string changed from "!" to "#". This should break some tests. I want to confirm that stuff fails.

@phil-davis phil-davis self-assigned this Feb 16, 2022
@phil-davis
Copy link
Contributor Author

Example: https://drone.cernbox.cern.ch/cs3org/reva/5716/9/6
various scenarios fail because they cannot detect the personal space id, which is what I expect from this test.

@phil-davis phil-davis closed this Feb 16, 2022
@phil-davis phil-davis deleted the break-test-fix-id branch February 16, 2022 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@labkode labkode Awaiting requested review from labkode labkode will be requested when the pull request is marked ready for review labkode is a code owner

@glpatcern glpatcern Awaiting requested review from glpatcern glpatcern will be requested when the pull request is marked ready for review glpatcern is a code owner

Assignees

@phil-davis phil-davis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phil-davis @micbar