Code

decomposedfs: add locking support#2460

Code

Merged

butonic merged 59 commits intocs3org:edgecs3org/reva:edgefrom butonic:decomposedfs-lockingbutonic/reva:decomposedfs-lockingCopy head branch name to clipboardFeb 9, 2022

+2,665-702

Commits

Commits on Feb 8, 2022

• decomposedfs: add locking support

  Show description for 6947e24
  butonic

  committed
  6947e24

  Copy full SHA for 6947e24

• add lock implementation, refactor error handling

  Show description for 4649185
  butonic

  committed
  4649185

  Copy full SHA for 4649185

• introduce lock ctx

  Show description for 2c7f7d3
  butonic

  committed
  2c7f7d3

  Copy full SHA for 2c7f7d3

• add locked error and status code mapping

  Show description for d0d0725
  butonic

  committed
  d0d0725

  Copy full SHA for d0d0725

• read lockid from opaque into ctx for delete

  Show description for 8e753e9
  butonic

  committed
  8e753e9

  Copy full SHA for 8e753e9

• decomposedfs: make delete respect lock

  Show description for a5bfd6a
  butonic

  committed
  a5bfd6a

  Copy full SHA for a5bfd6a

• ocdav: simplify error code mapping

  Show description for d45b84c
  butonic

  committed
  d45b84c

  Copy full SHA for d45b84c

• adjust to cs3 lock api update

  Show description for 9d5fe9d
  butonic

  committed
  9d5fe9d

  Copy full SHA for 9d5fe9d

• utils: add and read plain opaque entries

  Show description for b9ac3f5
  butonic

  committed
  b9ac3f5

  Copy full SHA for b9ac3f5

• fix delete lock

  Show description for 3630238
  butonic

  committed
  3630238

  Copy full SHA for 3630238

• invalidate stat cache when setting lock

  Show description for 0def9fd
  butonic

  committed
  0def9fd

  Copy full SHA for 0def9fd

• fix a few linter items

  Show description for 59e7bf1
  butonic

  committed
  59e7bf1

  Copy full SHA for 59e7bf1

• linter happyness

  Show description for a07f4bf
  butonic

  committed
  a07f4bf

  Copy full SHA for a07f4bf

• ocdav: implment unlock

  Show description for 65376ae
  butonic

  committed
  65376ae

  Copy full SHA for 65376ae

• lock caching and unlocking

  Show description for 96e4e09
  butonic

  committed
  96e4e09

  Copy full SHA for 96e4e09

• read locks on folders

  Show description for 35e0eab
  butonic

  committed
  35e0eab

  Copy full SHA for 35e0eab

• check lock on writes

  Show description for 942f8ea
  butonic

  committed
  942f8ea

  Copy full SHA for 942f8ea

• always assume locktype write

  Show description for e5ea694
  butonic

  committed
  e5ea694

  Copy full SHA for e5ea694

• ocis only supports exclusive locks

  Show description for d052abf
  butonic

  committed
  d052abf

  Copy full SHA for d052abf

• add precodition failed errtype

  butonic

  committed
  c6e394d

  Copy full SHA for c6e394d

• handle preconditionfailed in status conversion

  butonic

  committed
  e425727

  Copy full SHA for e425727

• omit empty xml tags in lockdiscovery

  butonic

  committed
  f427862

  Copy full SHA for f427862

• handle locked status on LOCK

  butonic

  committed
  4c95a65

  Copy full SHA for 4c95a65

• document oc10 lock behaviour as comment

  butonic

  committed
  78880f9

  Copy full SHA for 78880f9

• ocdav: handle errors for LOCK and UNLOCK

  butonic

  committed
  91f255a

  Copy full SHA for 91f255a

• storage: change fs.Unlock signature

  butonic

  committed
  826dcf9

  Copy full SHA for 826dcf9

• decomposedfs: refactor checkLock

  butonic

  committed
  9024756

  Copy full SHA for 9024756

• add LookupReferenceForPath comment

  Show description for 5c07bed
  butonic

  committed
  5c07bed

  Copy full SHA for 5c07bed

• gateway: ignore unimplemented add/denyGrant response

  Show description for 56b9f34
  butonic

  committed
  56b9f34

  Copy full SHA for 56b9f34

• use http.StatusMethodNotAllowed for mkcol error case

  Show description for bcd2bca
  butonic

  committed
  bcd2bca

  Copy full SHA for bcd2bca

• make hound happy

  Show description for a1a3e1e
  butonic

  committed
  a1a3e1e

  Copy full SHA for a1a3e1e

• ocdav: be more tolerant with the Lock-Token header

  Show description for c36b3bd
  butonic

  committed
  c36b3bd

  Copy full SHA for c36b3bd

• ocdav: allow setting infinity timeout

  Show description for 025ea39
  butonic

  committed
  025ea39

  Copy full SHA for 025ea39

• ocdav: use custem owner innerxml without href

  butonic

  committed
  10b97f9

  Copy full SHA for 10b97f9

• update expected failures

  butonic

  committed
  52f1bdd

  Copy full SHA for 52f1bdd

• ocdav: return conflict on missing intermediate target dir

  Show description for 9fa4418
  butonic

  committed
  9fa4418

  Copy full SHA for 9fa4418

• decomposedfs: use checkLock() in the rest of cases

  Show description for 87f8fb6
  butonic

  committed
  87f8fb6

  Copy full SHA for 87f8fb6

• Do not choke when checking the lock of non-existent nodes

  

  aduffeck

  authored and

  butonic

  committed
  02631d2

  Copy full SHA for 02631d2

• Linter fixes

  

  aduffeck

  authored and

  butonic

  committed
  c413855

  Copy full SHA for c413855

• Refactor: Move lock handling into the node domain

  

  aduffeck

  authored and

  butonic

  committed
  e26a5a6

  Copy full SHA for e26a5a6

• Also delete the lock file when deleting a node

  

  aduffeck

  authored and

  butonic

  committed
  870033a

  Copy full SHA for 870033a

• Extract node lock-handling code into separate file, start writing tests

  

  aduffeck

  authored and

  butonic

  committed
  22e6d1e

  Copy full SHA for 22e6d1e

• Add missing license header

  

  aduffeck

  authored and

  butonic

  committed
  a8efa41

  Copy full SHA for a8efa41

• Fix relocking already-locked nodes. Increase test coverage

  

  aduffeck

  authored and

  butonic

  committed
  8dfc038

  Copy full SHA for 8dfc038

• Hounds be happy

  

  aduffeck

  authored and

  butonic

  committed
  71315ad

  Copy full SHA for 71315ad

• Add unit tests for ReadLock and RefreshLock

  

  aduffeck

  authored and

  butonic

  committed
  94dec27

  Copy full SHA for 94dec27

• Also cover readLocksIntoOpaque in the tests

  

  aduffeck

  authored and

  butonic

  committed
  507f3c7

  Copy full SHA for 507f3c7

• Fix linter issue

  

  aduffeck

  authored and

  butonic

  committed
  24fc295

  Copy full SHA for 24fc295

• Do not log full nodes, it's very expensive and not very helpful

  

  aduffeck

  authored and

  butonic

  committed
  2e9a353

  Copy full SHA for 2e9a353

• Start adding grpc integration tests for locking

  

  aduffeck

  authored and

  butonic

  committed
  5e24a0c

  Copy full SHA for 5e24a0c

• Fix setting the lock for file uploads

  

  aduffeck

  authored and

  butonic

  committed
  40346bb

  Copy full SHA for 40346bb

• Allow for locking space-based resources

  

  aduffeck

  authored and

  butonic

  committed
  c6ec33e

  Copy full SHA for c6ec33e

• Make sure to log the error before it's getting overwritten

  

  aduffeck

  authored and

  butonic

  committed
  c6565bc

  Copy full SHA for c6565bc

• reuse xml.EscapeText directly

  Show description for 8a16f01
  

  butonic

  and

  C0rby

  committed
  8a16f01

  Copy full SHA for 8a16f01

• decomposedfs: use defer to close file when unlocking resource

  Show description for 00be883
  butonic

  committed
  00be883

  Copy full SHA for 00be883

• ocdav: explain why some http states are commented

  Show description for 4f67281
  butonic

  committed
  4f67281

  Copy full SHA for 4f67281

• ocdav: use http header status constants

  Show description for 59c90bc
  butonic

  committed
  59c90bc

  Copy full SHA for 59c90bc

• clarify add/deny grant log

  Show description for 047d843
  butonic

  committed
  047d843

  Copy full SHA for 047d843

• update expected failures

  Show description for d742652
  butonic

  committed
  d742652

  Copy full SHA for d742652