-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of CS3 Lock API for EOS storage driver #2444
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few changes here and there, let's discuss them later
75ff061
to
10b963b
Compare
This pull request introduces 2 alerts when merging 19f2b67 into 19246df - view on LGTM.com new alerts:
|
This pull request introduces 2 alerts when merging ba469cd into 19246df - view on LGTM.com new alerts:
|
This pull request introduces 2 alerts when merging 7a65ebe into 19246df - view on LGTM.com new alerts:
|
…et in GetLock function
This pull request introduces 1 alert when merging f39dbd2 into 5ba14cd - view on LGTM.com new alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have tested this now and it all works fine. Some caveats to be addressed in future PRs:
- Race conditions exist in some cases, and once EOS provides an endpoint to
flock
a file they will be fixed. - Attributes are currently stored on the version folder, but this can be reverted once the propagation of xattrs across versions is implemented in EOS (work in progress). This affects all xattrs, not just the locks.
Given that, the PR can be merged.
Once we reconcile with the edge branch, we could factorize out some common logic out of the decomposedfs
and eosfs
storage providers.
No description provided.