Merge user ACLs from EOS to sys ACLs #2247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ishank011
force-pushed
the
eos-file-perms
branch
from
524c98f to
917c7de
Compare
|
@ishank011 can you give an explanation for this fix? |
ishank011
force-pushed
the
eos-file-perms
branch
from
917c7de to
3631023
Compare
ishank011
force-pushed
the
eos-file-perms
branch
from
3631023 to
519aa3d
Compare
|
@labkode for file shares, we need to set user ACLs as EOS doesn't obey sys ACLs yet. These need to be passed as well when statting or listing resources. One use case is that when opening a file, we stat it to determine what permissions a user has on it to determine the view mode. |
labkode
approved these changes
Nov 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.