Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement the UpdateStorageSpace method #2162

Merged
merged 1 commit into from
Oct 22, 2021

Conversation

C0rby
Copy link
Contributor

@C0rby C0rby commented Oct 12, 2021

Added the UpdateStorageSpace method to the decomposedfs.
Users can now set a quota to their spaces (personal and project).

@C0rby C0rby requested a review from labkode as a code owner October 12, 2021 17:07
@C0rby C0rby marked this pull request as draft October 12, 2021 17:08
@C0rby C0rby force-pushed the update-storage-spaces branch from 26a33c0 to f557c2b Compare October 13, 2021 09:22
@C0rby C0rby marked this pull request as ready for review October 13, 2021 09:44
@C0rby C0rby self-assigned this Oct 13, 2021
refs
refs previously approved these changes Oct 13, 2021
@C0rby C0rby marked this pull request as draft October 14, 2021 09:39
@C0rby C0rby force-pushed the update-storage-spaces branch from f557c2b to 64d0de0 Compare October 14, 2021 10:00
refs
refs previously approved these changes Oct 14, 2021
ishank011
ishank011 previously approved these changes Oct 14, 2021
Copy link
Contributor

@ishank011 ishank011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@C0rby @refs good to merge?

@C0rby
Copy link
Contributor Author

C0rby commented Oct 14, 2021

No, not yet. We still need to have some permission checks but I need to clarify how to implement them.

@C0rby
Copy link
Contributor Author

C0rby commented Oct 20, 2021

Ok I have implemented the permission check in the graph service for now.

@C0rby C0rby marked this pull request as ready for review October 20, 2021 11:42
@C0rby C0rby dismissed stale reviews from ishank011 and refs via df8491c October 20, 2021 11:48
@C0rby C0rby force-pushed the update-storage-spaces branch from 64d0de0 to df8491c Compare October 20, 2021 11:48
@C0rby C0rby requested review from refs and ishank011 October 20, 2021 12:44
@C0rby
Copy link
Contributor Author

C0rby commented Oct 20, 2021

@ishank011, now it's good to go. I just rebased it. :)

@labkode labkode merged commit 2feb24b into cs3org:master Oct 22, 2021
@C0rby C0rby deleted the update-storage-spaces branch October 22, 2021 08:39
gmgigi96 pushed a commit to cernbox/reva that referenced this pull request Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants