-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement the UpdateStorageSpace method #2162
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C0rby
force-pushed
the
update-storage-spaces
branch
from
October 13, 2021 09:22
26a33c0
to
f557c2b
Compare
refs
previously approved these changes
Oct 13, 2021
C0rby
force-pushed
the
update-storage-spaces
branch
from
October 14, 2021 10:00
f557c2b
to
64d0de0
Compare
refs
previously approved these changes
Oct 14, 2021
ishank011
previously approved these changes
Oct 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, not yet. We still need to have some permission checks but I need to clarify how to implement them. |
Ok I have implemented the permission check in the graph service for now. |
2 tasks
C0rby
force-pushed
the
update-storage-spaces
branch
from
October 20, 2021 11:48
64d0de0
to
df8491c
Compare
@ishank011, now it's good to go. I just rebased it. :) |
micbar
approved these changes
Oct 21, 2021
labkode
approved these changes
Oct 22, 2021
gmgigi96
pushed a commit
to cernbox/reva
that referenced
this pull request
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the UpdateStorageSpace method to the decomposedfs.
Users can now set a quota to their spaces (personal and project).